Notification message when sending a reply

[rcubetrac]

Reported by sverre on 2 Dec 2008 11:21 UTC as Trac ticket #1485593

Hi, Just upped to r2107 from r2096. When sending a newly composed email or forwarding an existing email there is a message saying 'sending'. If you reply to an existing email the 'sending' message doesn't appear.

Steps to reproduce... Send yourself an email (notice 'sending' message) Forward your message to yourself (notice 'sending' message) Reply to your message (notice NO 'sending' message)

Just checked and the message was missing in r2096 too, I just hadn't noticed. I'm guessing this functionality has been lost so logging as a bug. Sorry, can't say when. Feel free to update my prioritisation / categories if inappropriate.

Regards, Sverre :-)

Migrated-From: http://trac.roundcube.net/ticket/1485593

[rcubetrac]

Comment by @alecpl on 2 Dec 2008 11:29 UTC

Works for me. Try with different browser. Some errors (in browser or in logs)?

[rcubetrac]

Owner changed by @alecpl on 2 Dec 2008 11:29 UTC

=> none

[rcubetrac]

Comment by sverre on 2 Dec 2008 11:43 UTC

Hmmm... I was using FireFox 3.0.4. Just tried in IE 7.0.5730.11 and the same. I'll download a complete SVN and do a compare.

[rcubetrac]

Comment by sverre on 2 Dec 2008 11:46 UTC

Only messages in log files are confirmations of the emails being sent.

[rcubetrac]

Comment by sverre on 2 Dec 2008 12:07 UTC

Okay, complete copy of latest SVN. Only thing I changed was the database connection and option to show errors plus I renamed the dist files.

The message does appear in Chrome 0.4.154.29, but does not appear in IE and FireFox (versions above). Haven't got anything else installed at work to test. Anybody else able to confirm / refute?

Regards, Sverre :-)

[rcubetrac]

Comment by @alecpl on 2 Dec 2008 12:28 UTC

One thing I can say. Debug app.js from line 902.

[rcubetrac]

Comment by sverre on 2 Dec 2008 13:12 UTC

It's line 912:

this.set_busy(true, 'sendingmessage');

Works in Chrome, doesn't work in IE / FireFox? Well, doesn't work when replying, but does when sending / forwarding??!!

[rcubetrac]

Comment by sverre on 2 Dec 2008 15:05 UTC

Tracing it through it appears to be something in the display_message function. It seems that the (!this.loaded) on line 3342 in app.js is true in FireFox and IE but not in Chrome:

  this.display_message = function(msg, type, hold)
    {
    if (!this.loaded)  // save message in order to display after page loaded
      {
      this.pending_message = new Array(msg, type);
      return true;
      }
    .
    .
    .

The function exits and the code to display the message is not executed. No idea why at the moment...

[rcubetrac]

Comment by @alecpl on 6 Feb 2009 10:40 UTC

Try with current svn-trunk. Works for me.

[rcubetrac]

Status changed by @alecpl on 6 Feb 2009 10:40 UTC

new => closed