Display message attachment's

[rcubetrac]

Reported by jasb on 27 Oct 2009 21:13 UTC as Trac ticket #1486246

Howdy, A message with an attach, instead of showing the message and the attach, RC show's the message, and the attach below the message.

I've tried one of the three configuration options and none worked.

// 0 - Full RFC 2231 compatible // 1 - RFC 2047 for 'name' and RFC 2231 for 'filename' parameter (Thunderbird's default)

// 2 - Full 2047 compatible

going to attach a raw message, that show's the attach message on any email client, MSO2007, SquirrelMail, Windows Mail (former Outlook Express), ThunderBird.

Migrated-From: http://trac.roundcube.net/ticket/1486246

[rcubetrac]

Comment by @alecpl on 28 Oct 2009 10:02 UTC

Attach BODYSTRUCTURE and some screenshots. It looks ok here. The options that you're talking about are not for messages displaying.

[rcubetrac]

Owner changed by @alecpl on 28 Oct 2009 10:02 UTC

=> none

[rcubetrac]

Milestone changed by @alecpl on 28 Oct 2009 10:02 UTC

later => 0.3.1

[rcubetrac]

Comment by jasb on 28 Oct 2009 11:29 UTC

Hi Allec, See the images I attached in the order (sc1/sc2/sc3).

[rcubetrac]

Comment by @alecpl on 28 Oct 2009 12:30 UTC

So, this looks almost like in Thunderbird2, but what we have here... A message with two parts. First part is displayed correctly. Second part is of type message/rfc822. Roundcube and Thunderbird are displaying such parts even with disposition=attachment set. Now, this part contains three subparts. First is displayed correctly. Second is a "Delivery report.dat" attachment, this is also ok, but the 3rd subpart is also message/rfc822. Here Roundcube is displaying both parts, text/plain and text/html and this is a bug. A second difference with TB is that TB lists disposition=attachment parts on attachment list, but should we do this if we're displaying their content?

[rcubetrac]

Comment by @alecpl on 28 Oct 2009 13:07 UTC

Attached simple patch, but here I'm not sure if this not breaks something else.

[rcubetrac]

Comment by jasb on 28 Oct 2009 14:26 UTC

Check the new screenshot's. I've applied your patch, something is different now. Is there a way to add an option to show the 1st attach like MSOutlook does? Show the attach only, and if I want to open the attach it'll let me? Going to attach a screenshot from MSO.

[rcubetrac]

Comment by @alecpl on 3 Dec 2009 09:56 UTC

(My patch applied in 3815e050). So, you just want to display all message/rfc822 parts as attachments on attachments list instead displaying them in the message window, below the main message?

[rcubetrac]

Comment by peridoc on 3 Dec 2009 18:34 UTC

I saw that this updated in the trunk last night and as of today I am not able to read my Sourceforge.net mail list digest emails that are sent in MIME format. I was able to read them yesterday before updating the code from the trunk (updated from the previous day's trunk version). Could this change have possibly broken reading them? Do I need to supply any items to help debug? Thnaks!

[rcubetrac]

Comment by @alecpl on 3 Dec 2009 19:08 UTC

@peridoc: yes, attache sample message, please.

[rcubetrac]

Comment by jasb on 3 Dec 2009 20:58 UTC

Hi Allec, Something's different now, but i believe it still need's some tune. Check my screenshot's, and raw msg.

[rcubetrac]

Comment by peridoc on 3 Dec 2009 21:11 UTC

Replying to alec:

@peridoc: yes, attache sample message, please.

I forgot to mention that I attached the sample message as requested. Sorry.

Thanks!

[rcubetrac]

Comment by @alecpl on 4 Dec 2009 10:51 UTC

Fixed in 19d6a893. @jasb: what you expect?

[rcubetrac]

Comment by jasb on 4 Dec 2009 11:28 UTC

Alec, It's perfect now! Thank you!

[rcubetrac]

Status changed by @alecpl on 4 Dec 2009 11:37 UTC

new => closed

[rcubetrac]

Comment by peridoc on 4 Dec 2009 14:05 UTC

I am fixed now too. Thank you very much!