search

roundcube / roundcubemail

The Roundcube Webmail suite
https://roundcube.net
GNU General Public License v3.0
5.59k stars 1.6k forks source link

Larry issues #3687

Closed rcubetrac closed 11 years ago

rcubetrac commented 12 years ago

Reported by @alecpl on 17 Feb 2012 08:31 UTC as Trac ticket #1488354

  1. jquery-ui popup's title bar could be thiner.[No title in contact photo upload popup.[BR]
  2. Wrong position of "Check spelling" link in plain text mode. Maybe we could integrate language selector with Spell button in toolbar, then the link could be removed.[Sometimes folders list footer is broken (misplaced icons and quota text).[BR]
  3. Folder selection highlights folder name, messages count of the folder, but also subfolders' counters.[Lack of "#mailboxlist li.recent" style.[BR]
  4. No left border in flag and listoptions column on messages list.["All headers" in message view could look better.[BR]
  5. Menu popups doesn't disapear when clicking on an iframe.[2px artefact at the bottom of Mark button.[BR]
  6. Wrong text with checkboxes alignment, e.g. in search menu.

Keywords: larry skin Migrated-From: http://trac.roundcube.net/ticket/1488354

rcubetrac commented 12 years ago

Comment by @alecpl on 20 Feb 2012 12:59 UTC

  1. different height of rows in two lists of Settings interface.
rcubetrac commented 12 years ago

Comment by @thomascube on 21 Feb 2012 17:40 UTC

Replying to alec:

  1. jquery-ui popup's title bar could be thiner.[was the designer's choice to make them this big. Consider it a style artefact.
  2. No title in contact photo upload popup.[[BR]([BR]]

It)]

We don't yet have a good concept to load localized texts which can then be used within skin scripts. Working on it.

  1. Wrong position of "Check spelling" link in plain text mode. Maybe we could integrate language selector with Spell button in toolbar, then the link could be removed.[link location is hard-coded in googiespell script.
  2. Sometimes folders list footer is broken (misplaced icons and quota text).[[BR]([BR]]

The)]

Sometimes? Reproducable?

  1. "All headers" in message view could look better.[[BR]]

I tried to simulate a box pulled out of the headers box. Any concerete suggestions?

  1. Wrong text with checkboxes alignment, e.g. in search menu.
  2. different height of rows in two lists of Settings interface.

Works for me. Browser? Screenshots?

rcubetrac commented 12 years ago

Comment by @alecpl on 21 Feb 2012 18:08 UTC

Replying to thomasb:

The link location is hard-coded in googiespell script.

Maybe, but we can modify it.

  1. Sometimes folders list footer is broken (misplaced icons and quota text).[[BR]]

Sometimes? Reproducable?

This is strange, see attachment taken in Chromium. After closing browser the issue disapear.

  1. Wrong text with checkboxes alignment, e.g. in search menu.

The same in Firefox and Chromium.

  1. different height of rows in two lists of Settings interface.

Firefox 10. The same issue in addressbook view. No problem in Chromium.

rcubetrac commented 12 years ago

Comment by @thomascube on 21 Feb 2012 22:09 UTC

Fixed 5. and 7. in [6. in b6837c37(3c9e9033],)

rcubetrac commented 12 years ago

Comment by @alecpl on 25 Feb 2012 07:42 UTC

I've observed 4th issue in IE8 (looks the same like in Chromium, see attachment.

rcubetrac commented 12 years ago

Comment by @alecpl on 25 Feb 2012 07:55 UTC

  1. doesn't look fixed in IE8 (subfolders' counters are being highlighted still).
rcubetrac commented 12 years ago

Comment by @thomascube on 25 Feb 2012 15:39 UTC

Fixed 9. and 5. for IE in 14a3f281

I still can't reproduce 4., 10., 11. in Firefox 10 or Chrome (I don't have Chromium). Please debug and fix it right on the browser where you observe the issues.

rcubetrac commented 12 years ago

Comment by @alecpl on 26 Feb 2012 16:17 UTC

  1. and 10. fixed in af5995d4.
rcubetrac commented 12 years ago

Comment by @alecpl on 27 Feb 2012 13:34 UTC

The fix for 6. could be better. Maybe use different color or change the color of messages counter too.

rcubetrac commented 12 years ago

Comment by @alecpl on 1 Mar 2012 12:48 UTC

I attached a patch which implements one button (with language selector) for html and plain spellcheckers in default skin. It's almost complete. Please, implement something similiar for larry.

rcubetrac commented 12 years ago

Comment by @alecpl on 5 Mar 2012 14:56 UTC

  1. searchfilter.decorated in Opera looks even worse than native select.
  2. Wrong cursor on autocomplete list.
rcubetrac commented 12 years ago

Comment by @alecpl on 5 Mar 2012 14:57 UTC

  1. Messages below the login box should be centered (most important for long texts)
rcubetrac commented 12 years ago

Comment by @alecpl on 6 Mar 2012 08:09 UTC

  1. buttons in mail toolbar are aligned to right, in addressbook to left. Alignment should be consistent. Also searchbox position should be considered.
rcubetrac commented 12 years ago

Comment by @alecpl on 6 Mar 2012 13:50 UTC

  1. editor_content.css file for html editor doesn't exist in Larry.
rcubetrac commented 12 years ago

Comment by @alecpl on 7 Mar 2012 12:38 UTC

  1. No quota indicator in folders manager.
rcubetrac commented 12 years ago

Comment by @alecpl on 8 Mar 2012 11:32 UTC

13., 14., 17. and 18. are fixed.

rcubetrac commented 12 years ago

Comment by @thomascube on 8 Mar 2012 19:53 UTC

Replying to alec:

  1. buttons in mail toolbar are aligned to right, in addressbook to left. Alignment should be consistent.

Toolbar buttons are located above the container box they actually affect. Right-aligning them in address book view would leave them over the detail box but they are related to the list.

Also searchbox position should be considered.

That's another topic. As already discussed on several lists and forums, this requires the entire header to be re-arranged. I forwarded the request to our designer and hopefully he'll come up with a suitable suggestion.

rcubetrac commented 12 years ago

Comment by @alecpl on 23 Mar 2012 09:37 UTC

Not fixed: 8., 12., 16.

rcubetrac commented 12 years ago

Comment by @alecpl on 4 Apr 2012 07:55 UTC

  1. Opera 11.62: wrong display of message list rows (thread children only), when message subject is longer than cell width.
rcubetrac commented 12 years ago

Comment by @alecpl on 4 Apr 2012 13:19 UTC

  1. It would be great to see "text-overflow: ellipsis" behaviour on some tables (e.g. identities list) instead of a horizontal splitter.
rcubetrac commented 12 years ago

Comment by @thomascube on 4 Apr 2012 18:08 UTC

Fixed 19. and 20. The splitter remains for consistency reasons.

rcubetrac commented 12 years ago

Comment by @alecpl on 14 Apr 2012 06:42 UTC

  1. Scrollbar and form buttons in iframes are sometimes partially hidden by statusbar. It's because the iframe style uses "height: 96%". Only message preview pane is free of this issue.
rcubetrac commented 12 years ago

Comment by @alecpl on 14 Apr 2012 06:46 UTC

  1. Height of quick-search box and filter selector is different. Would be better to use the same height.
rcubetrac commented 12 years ago

Comment by @alecpl on 25 Apr 2012 08:59 UTC

8th fixed in 76248c7b.

rcubetrac commented 12 years ago

Comment by @alecpl on 7 May 2012 09:24 UTC

  1. Something's changed and markasjunk and archive plugin buttons use icons from default skin with larry.
rcubetrac commented 12 years ago

Comment by @alecpl on 8 May 2012 12:24 UTC

  1. Message forward menu doesn't present default selection.
rcubetrac commented 12 years ago

Comment by @thomascube on 8 May 2012 20:19 UTC

Replying to alec:

  1. Something's changed and markasjunk and archive plugin buttons use icons from default skin with larry.

Empty folders got lost in git. Now fixed.

rcubetrac commented 12 years ago

Comment by @thomascube on 8 May 2012 20:22 UTC

Replying to alec:

  1. Message forward menu doesn't present default selection. That selection was confusing. It was not clear what happens when clicking where and saving prefs from a menu doesn't make sense to me. If you really insist in having a user-pref for that, it should be added to the settings section.
rcubetrac commented 12 years ago

Comment by @alecpl on 9 May 2012 06:08 UTC

Replying to thomasb:

That selection was confusing. It was not clear what happens when clicking where and saving prefs from a menu doesn't make sense to me. If you really insist in having a user-pref for that, it should be added to the settings section. I think it was quite good shortcut, but we can move this to Settings.

rcubetrac commented 12 years ago

Comment by @thomascube on 9 May 2012 09:19 UTC

  1. fixed in commit f8c9610f197b79ea2e0b3983ecffe4c145804d2e
rcubetrac commented 12 years ago

Comment by @alecpl on 17 May 2012 07:16 UTC

  1. Attachment list issue, see larry_issue25.png attachment to this ticket.
rcubetrac commented 12 years ago

Comment by @thomascube on 30 May 2012 08:34 UTC

Replying to alec:

  1. Attachment list issue, see larry_issue25.png attachment to this ticket.

Can you please attach or send me the message source? I need to be able to reproduce this somehow.

rcubetrac commented 12 years ago

Comment by @thomascube on 31 May 2012 13:29 UTC

  1. fixed in [fixed in 8ce60246(fcd3f571] 25.). The proper solution would be to add a toggle to hide/show the attachments list.

I guess we're more or less done with these issues now.

rcubetrac commented 12 years ago

Comment by @alecpl on 31 May 2012 13:52 UTC

21 is not really fixed (see attachment), 12 too. There's also 16 (but it's not a show stopper and we can exclude it to another ticket).

rcubetrac commented 11 years ago

Comment by @thomascube on 6 Jul 2012 10:55 UTC

  1. now fixed in 98d09600.
  2. isn't an issue anymore now that toolbar and search box position changed

I can't reproduce 12 on any of my browsers :-(

rcubetrac commented 11 years ago

Status changed by @thomascube on 6 Jul 2012 10:55 UTC

new => closed