search

roundcube / roundcubemail

The Roundcube Webmail suite
https://roundcube.net
GNU General Public License v3.0
5.78k stars 1.62k forks source link

Enigma plugin contains a very old copy of pear Crypt_GPG, even in the '-dep' tarball #4243

Closed rcubetrac closed 10 years ago

rcubetrac commented 11 years ago

Reported by AdamW on 18 Jun 2013 02:57 UTC as Trac ticket #1489182

The '-dep' tarball of Roundcube is supposed to contain no embedded external shared resources, for the convenience of distributors who are not allowed to provide software that contains these. However, in roundcubemail-0.9.2-dep.tar.gz , I see:

roundcubemail-0.9.2-dep/plugins/enigma/lib/Crypt

which contains what appears to be a rather old copy of this PEAR module:

https://github.com/pear/Crypt_GPG

Ideally, the enigma plugin should be written to work with an external Crypt_GPG, the embedded copy should be taken out of the enigma plugin, and the documentation should be updated to note Crypt_GPG as an optional external dependency (required for the enigma plugin to work).

Migrated-From: http://trac.roundcube.net/ticket/1489182

rcubetrac commented 11 years ago

Milestone changed by @alecpl on 18 Jun 2013 06:21 UTC

later => 1.0-beta

rcubetrac commented 11 years ago

Comment by @thomascube on 18 Jun 2013 06:46 UTC

Not sure whether this will ever be finished but we should definitely remove the enigma plugin from the release branches.

rcubetrac commented 11 years ago

Comment by @alecpl on 18 Jun 2013 06:47 UTC

Yes, that's the simplest solution.

rcubetrac commented 11 years ago

Comment by AdamW on 18 Jun 2013 07:58 UTC

Ah, I was assuming its presence in the release tarballs meant it was actually working now. If not, indeed it makes sense just to remove it.

rcubetrac commented 11 years ago

Comment by @alecpl on 21 Jun 2013 12:21 UTC

Thomas, I see you removed this plugin in release-0.9 branch. This is good. However, do not forget to add this action in the build script. Also, there's another plugin which uses external library plugins/managesieve/lib/Net/Sieve.php. I suppose this could/should be also removed from "dependent" package. Also, maybe we should list these plugins' dependencies in main INSTALL file.

rcubetrac commented 11 years ago

Owner changed by @alecpl on 9 Jul 2013 07:14 UTC

=> thomasb

rcubetrac commented 10 years ago

Comment by @alecpl on 6 Oct 2013 13:06 UTC

In 4daaa09438bc05f9d5d6cf339cc0b60b511057e9 external libs were moved into main Roundcube /lib directory and listed in Requirements section of INSTALL file. Thomas, please update build script to remove also lib/Crypt when creating dependent package.

rcubetrac commented 10 years ago

Status changed by @alecpl on 6 Oct 2013 13:06 UTC

new => closed