search

roundcube / roundcubemail

The Roundcube Webmail suite
https://roundcube.net
GNU General Public License v3.0
5.92k stars 1.64k forks source link

Remove "Add contact" link on contacts already in address book #4989

Open rcubetrac opened 15 years ago

rcubetrac commented 15 years ago

Reported by djib on 7 Sep 2009 13:15 UTC as Trac ticket #1486097

I suggest removing the "Add contact" link/icon when a user is already in the address book.

I enclose a patch for revision 2929.

Migrated-From: http://trac.roundcube.net/ticket/1486097

rcubetrac commented 15 years ago

Milestone changed by @alecpl on 7 Sep 2009 16:31 UTC

=> later

rcubetrac commented 15 years ago

Comment by @alecpl on 15 Sep 2009 09:14 UTC

Verified. We need also multicolumn index on user_id, email, del columns.

rcubetrac commented 15 years ago

Milestone changed by @alecpl on 15 Sep 2009 09:14 UTC

later => 0.3.1

rcubetrac commented 15 years ago

Comment by @thomascube on 25 Sep 2009 15:54 UTC

Well, of a user clicks the icon and address is already saved in the address book, an according messages appears. Due to performance reasons we should stick with that. Checking all addresses might slow down the message display.

rcubetrac commented 15 years ago

Severity changed by @thomascube on 25 Sep 2009 15:54 UTC

normal => minor

rcubetrac commented 15 years ago

Comment by @alecpl on 25 Sep 2009 16:01 UTC

This feature could be also extended to display link to addressbook info for known senders, but I agree with Thomas, for performance reasons we should make this optional.

rcubetrac commented 15 years ago

Milestone changed by @alecpl on 25 Sep 2009 16:01 UTC

0.3.1 => later

rcubetrac commented 15 years ago

Comment by @alecpl on 25 Sep 2009 16:02 UTC

...and this should be extended to check all addresses with one SQL query.

rcubetrac commented 15 years ago

Comment by djib on 25 Sep 2009 16:09 UTC

I really like this feature because it allows me to quickly check if a friend is already in my address book. Does it really have that big an impact on performance?

rcubetrac commented 15 years ago

Comment by @alecpl on 25 Sep 2009 16:18 UTC

It could have. If you have big addressbook, slow database or many addresses to check. Another solution is to sent checking ajax request after displaying a message.