roundcube / roundcubemail

The Roundcube Webmail suite
https://roundcube.net
GNU General Public License v3.0
5.89k stars 1.64k forks source link

Automatically remove inline/embeded images on forward message #6767

Open numericOverflow opened 5 years ago

numericOverflow commented 5 years ago

Similar to #6619 , but I don't want to resend any attachments when replying to an image. This means removing those embedded into the HTML message.

Is this possible now through a setting, or by adding a button if not available?

When working with emails that have lots of embedded images (think professional signature banners & social media icons) they all have to be deleted individually. A single button to remove them all would be very useful, or a setting to never resend original attachments in reply (embedded or attached).

2018-12-19_170831

alecpl commented 5 years ago

A new option or button does not sound right. I think the solution to this problem would be following.

numericOverflow commented 5 years ago

I was thinking something like the link that shows up when you preview an email that has attachments (as proper attachments, not inline/embedded):

Remove_all_attachements_option

If that "Remove All Attachments" link were placed at the bottom of the list of attachments, you could click that one link instead of having to click the garbage can icons on each and every attachment to delete them all.

I'd say there are legit times where I want to include attachments on forwarding an email, but often times they aren't needed so I think it still makes sense to have the option of removal to reduce message size.

The idea was more about streamlined mass-removal, not necessarily truly automated removal of attachments. I was suggesting a UX improvement to reduce tons of clicks.

alecpl commented 5 years ago

But if we remove inline images from the list, the button will become much less needed.

numericOverflow commented 5 years ago

OK. Am I correctly interpreting how your proposed fix would work with the following two use cases?

  1. I want to forward an email with all of the original inline images

    • I assume this is simple, they are just handled behind the scenes and it happens automagically.
  2. I want to forward an email without any of the original inline images

    • I assume I have to delete each inline image from the message body pane, one-by-one.
      • If that's the case, it's almost worse than current functionality because I have to dig them all out of the message body individually instead of from a single, central list in the attachments pane.
alecpl commented 5 years ago

Well, handling 2. your way would cause the message body to contain references to non-existing images. It does not make sense to me. Imo, the point is to control via the message body which images are attached and which not.

ObaSensei commented 5 years ago

How do I have the inline messages still show up but not on the attachments?

alecpl commented 4 years ago

@ObaSensei, that's what we're discussing as a solution. It's not possible at the moment.