search

roundcube / roundcubemail

The Roundcube Webmail suite
https://roundcube.net
GNU General Public License v3.0
5.89k stars 1.64k forks source link

Javascript overriding $config['search_scope'] setting? #8198

Closed sdondley closed 3 years ago

sdondley commented 3 years ago

Using 1.4.11.

I have the $config['search_scope'] = 'all' in my config file.

However, when I click in new folder and open the search menu, the search setting defaults to 'current folder'. I have to manually refresh the page to get the 'all folders' setting to kick in. It seems like some javascript might be overriding the initial setting of the search scope. Not sure, though.

Please advise.

Same problem is happening on Elastic and Larry.

sdondley commented 3 years ago

Based on some tinkering I did, I suspect there is some kind of caching of app.min.js that is the cause of the problem. I think this line:

scope = this.env.search_scope || 'base',

it's loading very old, stale values. But I'm not sure because I have no idea how js caching might be set up with roundcube.

But by tinkering with this line in app.min.js and forcing it to all lke so:

scope = this.env.search_scope || 'all',

I got things to work properly. I'm just not sure how to flush the cache to get the changes to take consisently.

sdondley commented 3 years ago

Alright, I think the problem is that app.min.js is a stale minimized copy of a older version of app.js.

If I simply overwrite app.min.js with app.js, and now things work as expected.

Don't know if this is a debian package manager's issue or what. At any rate, things are woking perfectly using the non-minimized version of app.js.

sdondley commented 3 years ago

After minifying app.js manually and replacing app.min.js, everything still works. So yeah, looks like a stale copy of app.min.js was shipped with the debian package I'm using.

sdondley commented 3 years ago

I've made an attempt to report this issue to the debian package manager: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994068