search

roundcube / roundcubemail

The Roundcube Webmail suite
https://roundcube.net
GNU General Public License v3.0
5.88k stars 1.64k forks source link

Dark mode to user preferences #8951

Open rokj opened 1 year ago

rokj commented 1 year ago

Some of our users reported that elastic theme does not "save" dark mode after logout.

We solved it with saving dark mode (color_mode) to user preferences instead of saving it to the cookie; something like: https://github.com/roundcube/roundcubemail/compare/master...rokj:roundcubemail:color-mode-to-prefs

Also removed setting dark mode with javascript on page load since this disables flickering.

bandisast commented 1 year ago

Which Roundcube version and which browser? :)

rokj commented 1 year ago

Which Roundcube version and which browser? :)

RC 1.6.1, any browser, random user. I could not reproduce the problem, but my colleague was able to, even though we cannot tell the differences between users.

We assume it has something to do with cookies or something, so we tried to save color mode to user preferences rather than into the cookie. It also "saves" color mode for browser change ...

alecpl commented 1 year ago

It has pros and cons. I'm not sure.