Fix "Implicit array creation" in plugin config files

roundcube / roundcubemail

The Roundcube Webmail suite

https://roundcube.net

GNU General Public License v3.0

5.57k stars 1.6k forks source link

Fix "Implicit array creation" in plugin config files #9406

Closed mvorisek closed 1 month ago

mvorisek commented 1 month ago

extracted from #9241

"Implicit array creation" PHPStan error is otherwise present once the plugins are installed.

Also require Roundcube for all the bundled plugins - https://github.com/roundcube/plugin-installer/pull/44.

alecpl commented 1 month ago

Looks good with one note. The plugins repository was left there for backward compat. with plugins that do not exist on Packagist yet. So, again, this part probably would be easier to accept if we do a bigger jump in version number (v2.0).

mvorisek commented 1 month ago

I read somewhere the plugins repository is no longer in operation...

I have dropped the https://github.com/roundcube/roundcubemail/commit/bd17e2ed97002c887f91d8d3df99c1b307b153b0 commit. Can this PR be merged now?