Open jaudriga opened 1 month ago
@jaudriga After reading the corresponding ticket I'm wondering you want this actually merged or if it's more of a proof of concept to illustrate your broader request?
@pabzm
It would be great to have this merged as this is an obvious and straight forward aspect of #9377 to address for me.
I realize that that might not address all aspects of #9377 , however, its an important and good step in the right direction.
Addressing even broader changes would be great, but not strictly necessary in my opinion. I would need a bit more support for those as a bunch of design decisions would need to be taken that I am not comfortable taking on my own.
I would suggest that we focus on this PR for now and potentially discuss about further improvements in #9377 .
I rebased on newest master as on of the CI jobs failed: https://github.com/roundcube/roundcubemail/actions/runs/9059543070/job/24905660338
The CI will be fixed with #9449, please rebase again after that was merged.
I rebased again ;)
@alecpl Any thoughts on this?
Addresses #9377 .
Main change: Allows to use the
rcmail::login()
function for merely logging into IMAP by introducing a new flag$just_connect
. This allows applications using the Roundcube Framework to reuse IMAP authentication logic.Background: It would be beneficial for applications like Roundcube JMAP (see https://github.com/audriga/roundcube-jmap/pull/6 ) or Kolab's FreeBusy to reuse large parts of the existing IMAP Authentcation logic of Roundcube. This is my try at providing an interface for reusing that.
Minor additional change: Adds a function in rcube to connect to IMAP. I actually consider this optional as its only beneficial for FreeBusy for now. This would basically allow FreeBusy to just call
rcube::imap_connect()
instead of what they are doing right now (from lib/Kolab/FreeBusy/SourceIMAP.php):