search

roundcube / roundcubemail

The Roundcube Webmail suite
https://roundcube.net
GNU General Public License v3.0
5.59k stars 1.6k forks source link

Update .gitignore #9455

Closed gerbert closed 1 week ago

gerbert commented 2 weeks ago

Added JetBrains PhpStorm project folder (.idea)

gerbert commented 2 weeks ago

One minor note I noticed in .gitignore, lines 25-27. Shouldn't the path be relative?

# eslint dependencies                                                            
/node_modules
/package.json
/package-lock.json
pabzm commented 1 week ago

Shouldn't the path be relative?

The paths are all relative to the repo's root directory, see https://git-scm.com/docs/gitignore#_pattern_format:

If there is a separator at the beginning or middle (or both) of the pattern, then the pattern is relative to the directory level of the particular .gitignore file itself. Otherwise the pattern may also match at any level below the .gitignore level.

pabzm commented 1 week ago

@alecpl I allowed myself to merge without further review because the change is so tiny and simple.

gerbert commented 1 week ago

Shouldn't the path be relative?

The paths are all relative to the repo's root directory, see https://git-scm.com/docs/gitignore#_pattern_format:

If there is a separator at the beginning or middle (or both) of the pattern, then the pattern is relative to the directory level of the particular .gitignore file itself. Otherwise the pattern may also match at any level below the .gitignore level.

Well, thanks for pointing out, never knew, actually. Might be handy in the future.