search

roundware / roundware-android

Android client for Roundware contributory audio platform
http://roundware.org
GNU General Public License v3.0
5 stars 6 forks source link

Record UI progression is awkward and adds extra Activities to the stack #23

Open multidynamic opened 9 years ago

multidynamic commented 9 years ago

Matthew Adler created an issue 2014-12-10 The way screens are pushed/popped as well as their transitions are awkward. I'd expect to be returned after indicating my recording. Or is the intention user wants to make multiple recordings?

Halsey Burgund REPO OWNER 2014-12-10 FYI, this is something that didn't happen in older versions of Android RW apps (mainly running on 2.3), so it may be related to 4/5? Or some code may have fundamentally changed recently...not sure. If you think it's possibly the latter, I can get you access to the apps that don't have this issue so you can poke around in the code if that would be useful. And the intention is NOT that the user would want to make multiple recordings immediately. Users can make multiple recordings by actively pressing the "Record Again" button on the Thank You screen, but there shouldn't be any automatic expectation of multiple recordings.

13rac1 commented 9 years ago

Part of the problem is: https://github.com/roundware/roundware-android/blob/7e3930dc2252f8e5bf76fc3de61034142bc5bb4a/rwapp/src/main/java/org/roundware/rwapp/RwSpeakActivity.java#L515

mListenMoreButton.setOnClickListener(new View.OnClickListener() {
    @Override
    public void onClick(View v) {
        // TODO: quick hack - not the best way to do it
        startActivity(new Intent(getApplicationContext(), ClassRegistry.get("RwListenActivity")));
    }
});
multidynamic commented 9 years ago

@eosrei perhaps instead of pushing a ListenActivity, maybe we can just pop the activity stack. By calling finish() on the current activity. (Effectively going back.) You could make the icon conditional on whether it was pushed from the MainActivity or the ListenActivity.

multidynamic commented 9 years ago

I noticed the handling a back at the Android share dialog sends the user back to the choice webview, but with the selections unfunctional! Add something to catch that.

As a user I sort of expect the 3 2 1 countdown to begin after the user affirms the re-record alert dialog, but thats minor.

hburgund commented 9 years ago

Has anyone looked at the older code to determine what is different now? I have code for a different app that implements the original code for this app and it doesn't have this issue. I know a ton of changes have happened by several different people, so it seems possible something got wacko in the process. Happy to share this code if you think it might be useful.

13rac1 commented 9 years ago

Here's the code from the initial commit (FYI it's the same): https://github.com/roundware/roundware-android/blob/f6c7fdf49f2768d977fdf6196f39365f2d33f39e/SFMS/src/main/java/edu/si/sfms/SFMSSpeakActivity.java#L530

multidynamic commented 9 years ago

Upon investigation I noticed several issues related to this one. I am going to make this the parent issue and track the other serious issues separately.

multidynamic commented 9 years ago

I also noticed cosmetic issues: