search

route360 / r360-js

Route360° JavaScript API (now Targomo)
https://www.targomo.com/developers/
MIT License
174 stars 37 forks source link

Update LeafletPolygonLayer.js #24

Closed kutensky closed 8 years ago

kutensky commented 8 years ago

In leaflet v.1.0.0rc1 when you do initialize polygon layer with "var layer = r360.leafletPolygonLayer()" and then add it to map with "layer.addTo(this.map);" it throws an exception because it tries to call "_layerAdd" on layer to inform layer that it was added to map. That's why I propose to add "_layerAdd" function that will redirect call to "onAdd" function

gerbsen commented 8 years ago

hey @kutensky thanks for sharing this with us! have you had any other problems with leaflet 1.0? haven't had time to do anything myself so far :/ (do you have a demo somewhere?)

5chdn commented 8 years ago

leaflet 1.0 introduces a couple of api changes which are not backwards compatible. upgrading r360 to leaflet 1.0 should be considered carefully.

kutensky commented 8 years ago

No, I don't have public demo. Maybe I'm not using all features that route360 represent, but after this one small fix everything is working as expected.

2016-06-10 0:45 GMT-07:00 Afri notifications@github.com:

leaflet 1.0 introduces a couple of api changes which are not backwards compatible. upgrading r360 to leaflet 1.0 should be considered carefully.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/route360/r360-js/pull/24#issuecomment-225114992, or mute the thread https://github.com/notifications/unsubscribe/AEiDWHca4IjQ94ve-bJovpTM6lAQpsfnks5qKRYHgaJpZM4IygWS .

kutensky commented 7 years ago

Hello. I faced a problem. I just update r360 to the latest version and I get this error when trying to get polygons information from your servers [image: Встроенное изображение 1]

2016-06-10 19:52 GMT+03:00 Ihor Kutenskyi kutensky@gmail.com:

No, I don't have public demo. Maybe I'm not using all features that route360 represent, but after this one small fix everything is working as expected.

2016-06-10 0:45 GMT-07:00 Afri notifications@github.com:

leaflet 1.0 introduces a couple of api changes which are not backwards compatible. upgrading r360 to leaflet 1.0 should be considered carefully.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/route360/r360-js/pull/24#issuecomment-225114992, or mute the thread https://github.com/notifications/unsubscribe/AEiDWHca4IjQ94ve-bJovpTM6lAQpsfnks5qKRYHgaJpZM4IygWS .

gerbsen commented 7 years ago

I can't see any image? Could you provide a CURL/WGET request?

kutensky commented 7 years ago

Try this https://drive.google.com/file/d/0Bzb7kdOAE7MddWtSNlJ3VnJ0QzQ/view?usp=sharing

2017-10-13 15:54 GMT+03:00 gerbsen notifications@github.com:

I can't see any image? Could you provide a CURL/WGET request?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/route360/r360-js/pull/24#issuecomment-336444473, or mute the thread https://github.com/notifications/unsubscribe-auth/AEiDWLK0r_d5p8oWJlSvCowBpA4Fjilqks5sr12YgaJpZM4IygWS .

kutensky commented 7 years ago

It's basically forbidden http error. I thought maybe it's because I use http on local machine. But switching to self-signed https doesn't help

2017-10-13 16:03 GMT+03:00 Ihor Kutenskyi kutensky@gmail.com:

Try this https://drive.google.com/file/d/0Bzb7kdOAE7MddWtSNlJ3VnJ0QzQ/ view?usp=sharing

2017-10-13 15:54 GMT+03:00 gerbsen notifications@github.com:

I can't see any image? Could you provide a CURL/WGET request?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/route360/r360-js/pull/24#issuecomment-336444473, or mute the thread https://github.com/notifications/unsubscribe-auth/AEiDWLK0r_d5p8oWJlSvCowBpA4Fjilqks5sr12YgaJpZM4IygWS .

gerbsen commented 7 years ago

@kutensky can you please open an issue and provide some code snippet (a full url or a curl request)? This is a merged Pull request and will no longer be maintained.

kutensky commented 7 years ago

Sorry. I was answering to email. Didn't notice it automatically posts to github

2017-10-16 12:34 GMT+03:00 gerbsen notifications@github.com:

@kutensky https://github.com/kutensky can you please open an issue and provide some code snippet (a full url or a curl request)? This is a merged Pull request and will no longer be maintained.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/route360/r360-js/pull/24#issuecomment-336833189, or mute the thread https://github.com/notifications/unsubscribe-auth/AEiDWB26Ztx_L1gCLYGb3XAbOlCXJrmXks5ssyMkgaJpZM4IygWS .