search

router5 / react-router5

Helpers for using router5 with React [MOVED]
MIT License
83 stars 8 forks source link

"// Is it overkill?" How to make <Link> re-render when children change? #6

Closed vojtech-dobes closed 9 years ago

vojtech-dobes commented 9 years ago

If I understand the code correctly, custom shouldComponentUpdate prevents re-render when only children change. How to solve this?

troch commented 9 years ago

shouldComponentUpdate could be removed, I think for a small component like tat, re-rendering a single virtual DOM element for nothing is not that expensive.

troch commented 9 years ago

Removed and 0.1.5 released

vojtech-dobes commented 9 years ago

Thanks!