router5 / react-router5

Helpers for using router5 with React [MOVED]
MIT License
83 stars 8 forks source link

More fine-grained detection of activeness #8

Closed vojtech-dobes closed 9 years ago

vojtech-dobes commented 9 years ago

Let's consider example:

<Link routeName="foo">
</Link>

I don't use strict comparison, so I expected this link would be marked as active because /foo and /foo?bar=1 seem to me pretty much same. Unfortunately there is no support for such low level distinction. Would you consider adding support for this (basically stripping query parameters from current route unless they are part of link's route)?

troch commented 9 years ago

This is a good suggestion. I'll add an option to .isActive to include or not query params (default to false).

vojtech-dobes commented 9 years ago

:+1:

troch commented 9 years ago

Released with router5@0.9.0