Closed RealEnder closed 6 years ago
That is good enough.
On Sun, Apr 1, 2018 at 6:32 PM Alex Stanev notifications@github.com wrote:
@RealEnder commented on this pull request.
In cli/routerkeygen-cli.cpp https://github.com/routerkeygen/routerkeygenPC/pull/40#discussion_r178462982 :
- std::cout << QObject::tr("Errors while calculating.").toUtf8().data() << std::endl;
- continue;
- }
- }
- if (results.isEmpty()) {
- if ( !options.value("q", false).toBool() )
- std::cout << QObject::tr("No keys were calculated.").toUtf8().data() << std::endl;
- return -1;
- }
- if ( !options.value("q", false).toBool() )
- std::cout << QObject::tr("Calculated Passwords for %1").arg(wifi.getSsidName()).toUtf8().data() << std::endl;
- for (int i = 0; i < results.size(); ++i)
- std::cout << results.at(i).toLatin1().data() << std::endl;
- }
- return 0; +}
Searched for some examples and found something like this: https://github.com/QNapi/qnapi Taking this route requires way more infrastructure changes. How about just removing cli options from gui version? This will move the code only in -cli and if somebody needs cli interface it will be better to just use the -cli version anyway.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/routerkeygen/routerkeygenPC/pull/40#discussion_r178462982, or mute the thread https://github.com/notifications/unsubscribe-auth/AASi2X5BEn5nn9HDFeVRak1anC5KNyBSks5tkQEigaJpZM4SlmRw .
Moved options to -cli version. Still don't like it much, but works well :)
This is useful for running routerkeygen on headless server