search

rouzwawi / grpc-kotlin

gRPC with Kotlin Coroutines
https://gitter.im/gRPC-Kotlin/Lobby
Apache License 2.0
220 stars 23 forks source link

Why only unix systems? #29

Closed kptlronyttcna closed 4 years ago

kptlronyttcna commented 5 years ago

Is there something really hard about supporting windows? If you know what's the issue, maybe I can help.

rouzwawi commented 5 years ago

@kptlronyttcna It's just that I don't have access to a Windows environment to test it. I believe you need to attach additional artifacts to the -gen module that are executable on windows. It should be pretty similar to how they are adressed for the grpc generator (${os.detected.classifier} part):

io.grpc:protoc-gen-grpc-java:${grpc.version}:exe:${os.detected.classifier}

Seems like they are producing these artifacts with gradle: https://github.com/grpc/grpc-java/blob/master/compiler/build.gradle#L233-L240

fatfatson commented 5 years ago

@rouzwawi still don't know where to modify...could you give more hints? I'd like to build my project with this plugin in windows.

I think there are two steps need to perform:

  1. build an exe artifact
  2. add a config to let protoc using the exe in windows.

but I don't know how to make any of them :(

fatfatson commented 5 years ago

I have managed to build the exe by launch4j, then set its path to the grpckotlin plugin config in gradle , so I could build my project in windows but I still don't know how to publish it..

rouzwawi commented 4 years ago

This was fixed with #44 and is available from v0.1.3. See instructions in README for how to run the plugin.