Recent Django / Python improvements

roverdotcom / django-inlinecss

A Django app useful for inlining CSS (primarily for e-mails)

Other

160 stars 94 forks source link

Recent Django / Python improvements #51

Open WhyNotHugo opened 4 years ago

WhyNotHugo commented 4 years ago

Stop using deprecated smart_text, which is a warning on Django 3.0, and will fail with the next major release ~(note: smart_str is already present in Django 1.11, so this doesn't drop support for that)~. Django 1.11 won't work on recent (and not-so-recent) versions of Python, so drop that too. It's already past its EOL too.
Drop Pythons that have reached EOL.
Add newer Pythons to CI, and the README (side note; I've been using this with Django 3.0 on Python 3.8 for months with no issues, so just making support official).

Note: Projects that can't update for some reason can still use older versions of this library anyway, anyone using such old Pythons/Django already has pinned dependencies anyway.

Mogost commented 4 years ago

@melinath @roverdotcom Could you merge these changes?

melinath commented 4 years ago

Sorry, I'm no longer at Rover. @philipkimmey - heads up if you want to take a look at this!

WhyNotHugo commented 4 years ago

Ah, thanks for the heads up. If there's no longer anyone dedicated to maintaining the project, what do you think of moving this to Jazzband to be community-maintained?

Mogost commented 4 years ago

Totally agree for JazzBand. But we need to hear someone from the @roverdotcom.

philipkimmey commented 4 years ago

Hey @WhyNotHugo + @Mogost !

Sorry for the radio silence here - I wrote this many years ago and we don't really use it internally anymore so I think moving it to JazzBand is a great idea.

If you add me as a member there I'm happy to transfer it over and whatnot!

Mogost commented 4 years ago

If you add me as a member there I'm happy to transfer it over and whatnot!

JazzBand membership is open. You can join at any time. More information is available on the JazzBand site.

If the JazzBand does not accept us, I see @WhyNotHugo as a good candidate to pick up this project. As far as I can see, this fork belongs to you.

philipkimmey commented 4 years ago

Whoops - sorry about that, that makes sense. I'm signing up over there now.

WhyNotHugo commented 4 years ago

Many thanks for addressing that! You might also need to grant PyPi permissions for future releases.

onekiloparsec commented 4 years ago

Any hope this great PR will be merged and released ? 🙏

heidi-hayden commented 4 years ago

@WhyNotHugo - did you take control of this lib?

WhyNotHugo commented 4 years ago

@heidi-hayden nope.

I was hoping it'd be moved into jazzband, but still waiting on that.

jkeyes commented 3 years ago

@philipkimmey is there a reason why this project hasn't moved to JazzBand yet? It seems a shame to let this sit idle when there appears to be people willing to maintain it. Not sure what I can contribute at this stage, but if I can help out with getting things moving let me know.

WhyNotHugo commented 3 years ago

I've pushed django-inlinecss-redux==0.4.0.

https://github.com/WhyNotHugo/django-inlinecss/tree/v0.4.0