search

roverdotcom / django-inlinecss

A Django app useful for inlining CSS (primarily for e-mails)
Other
160 stars 94 forks source link

Django4 #58

Open blocher opened 2 years ago

blocher commented 2 years ago

Change to run with Django 4.0+: using smart_str instead of smart_text

theblueskies commented 2 years ago

@roverdotcom Can this be merged in please?

radokristof commented 2 years ago

I really need this. Please merge.

jeloagnasin commented 2 years ago

You can use this branch directly with pip or poetry:

$ poetry add git+https://github.com/blocher/django-inlinecss.git#django4

or

$ pip install django-inlinecss@git+https://github.com/blocher/django-inlinecss.git@django4
Achilles0509 commented 2 years ago

I tried to update Django version to 4.0.6, but failed due to this package.

sshishov commented 2 years ago

Do we have a people with Merge/Release abilities for this repo? Who is the maintainer?

sshishov commented 1 year ago

Hello,

We are using it, but because of legacy issues... We just cannot get rid of it instantly, but at the same time we are having deprication policy for it.

I have tried to contact the author, no luck... The only downside - either you will have to use forks to support newer python versions or Django versions, or you have to stuck at old dependencies, meaning all your stack will be outdated.

We are updating our deps constantly, therefore it is not good for us to stuck in the past...

Note: but the package is still working, even for new codebase - you can find a fork in the issue comments.

On Tue, May 16, 2023, 17:08 thomasb @.***> wrote:

Is this module worth forking if it's not currently being maintained?

— Reply to this email directly, view it on GitHub https://github.com/roverdotcom/django-inlinecss/pull/58#issuecomment-1549640057, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUWBFEVJFVTAEFJX3UVBL3XGN36VANCNFSM5O3RHSNA . You are receiving this because you commented.Message ID: @.***>