roverdotcom / django-inlinecss

A Django app useful for inlining CSS (primarily for e-mails)

Other

160 stars 94 forks source link

[DEV-103519] Upgrade to Django 4.2. Switch from travis to GHA #66

Closed JVenberg closed 9 months ago

JVenberg commented 9 months ago

What is the reason for this PR?

We are upgrading this library to support Django 4.2. As a result, we are updating the requirements to be Python>=3.8 and Django >=3.2

We no longer use travis to run our CI/CD tests. Our standard here at Rover is to use Github Actions. This switches the testing of different python versions over to GHA.

Validation

How will we know this is working?

This PR should have all tests passing.
After merging, the master branch should have all tests passing

JVenberg commented 9 months ago

Overall looks ok to me, just a question on some of the config. I don't have the Travis config for reference

Here is all we removed regarding Travis. I don't know if we've had a Github Travis integration for a long while