search

rovo89 / XposedInstaller

3.89k stars 1.51k forks source link

How about use getLinkTextColors instead of android.R.attr.textColorLink #190

Closed liudongmiao closed 10 years ago

liudongmiao commented 10 years ago

In https://github.com/rovo89/XposedInstaller/blob/master/src/de/robv/android/xposed/installer/DownloadDetailsFragment.java#L67, it uses

txtValue.setTextColor(ThemeUtil.getThemeColor(getActivity(), android.R.attr.textColorLink));

This doesn't work on Gingerbread, and it's a bit complex. How about use 

txtValue.setTextColor(txtValue.getLinkTextColors())

Furthermore, getThemeColor only returns a single color, and getLinkTextColors returns ColorStateList.

It's so simple, so I didn't issue a pull request.

rovo89 commented 10 years ago

I wasn't aware that such a method exists. I would obviously need to test it, but if it's working fine, I can use it instead.