Show toast when downloads are disabled

rovo89 / XposedInstaller

3.9k stars 1.51k forks source link

Show toast when downloads are disabled #251

Closed pylerSM closed 8 years ago

rovo89 commented 9 years ago

I was actually thinking about displaying a message instead of the white fragment. ;) The toast disappears rather fast.

Or alternatively, maybe the "Download" items in the navigation should go away completely? From user experience point of view, it would avoid offering an option that basically does nothing. A possible downside might be that the user might not remember he has disabled downloads in the settings. Any opinions on this?

pylerSM commented 9 years ago

Maybe show red warning "Downloading modules is disabled." below "Download" in navigation view? Just like when there are new updates we can see green info message. Edit: Looked on code, we can reuse R.id.txtUpdateAvailable but it wouldn't look well to use this element and show info about downloads.

And disable access to this section too.

pylerSM commented 9 years ago

But maybe good way is also simply show AlertDialog title - Disabled downloads msg - Downloading modules is disabled. Please enable it in Settings.

pylerSM commented 9 years ago

Ideas:

Add Enable button to this dialog, which will directly enable downloads.
Change OK button to "Open Settings" button. (I think this is the best solution, isn't it? @rovo89 )

Waiting for your comments.