search

rovo89 / XposedInstaller

3.9k stars 1.51k forks source link

Source code of AndroidHiddenAPI.jar #386

Open Bubu opened 7 years ago

Bubu commented 7 years ago

Where can we find the source code corresponding to the AndroidHiddenAPI.jar file? How can this be build?

Is it actually still used? Because it hasn't been updated for over 2 year. Any input would be appreciated.

rovo89 commented 7 years ago

Actually, I'm not sure how I created that file... But it only contains a single class, android.os.FileUtils. I could probably convert this to use reflection instead.

Bubu commented 7 years ago

Thanks for your answer!

Not including this jar file would enable F-Droid to fully build the xposed installer from source. (See https://gitlab.com/fdroid/rfp/issues/331)

rovo89 commented 7 years ago

OK! Please understand though that this doesn't have high priority for me.

Hm, and actually, it should be enough to keep this as provided dependency, not compile. The included class is present in Android itself, the app should just reference it instead of including it. I haven't tested this yet, but that would be a trivial change until I have converted all the calls. Maybe that would be more acceptable, given that there would be no "unknown" code actually included in the APK?

dimqua commented 7 years ago

@Bubu is this acceptable? Works for me, btw.

Bubu commented 7 years ago

I think this should be fine for f-droid then but let's hear what others have to say in rfp#331.