search

rowak / nanoleaf-desktop

A modern desktop application for the Nanoleaf Aurora and Canvas
MIT License
166 stars 13 forks source link

Wrong shapes #32

Closed resteqs closed 2 years ago

resteqs commented 3 years ago

My triangles are recognized as Hexagons and i have no possibility to change it. In the official app everything is fine so it has to be problem with this client (btw expect for this bug its great :D )

rowak commented 3 years ago

Do you have the original triangle lights (Aurora) or the new triangle lights (Shapes Triangles)? The Aurora lights definitely shouldn't behave this way, but this Shapes Triangles are unsupported.

I don't currently know of a reliable way to identify the different Shapes devices, however, I can try whitelisting your device model as a bit of a workaround. Try running this program (which outputs some basic device info) then copy the output it gives you and paste it here. You should see your device's name, model, and some other info.

resteqs commented 3 years ago

Yes I have the newer triangles. Correct me if I'm wrong, but wouldn't it be easier if after the "Hexagons" get recognized a pop up shows up where the user can choose what kind of panels he has? It's not an optimal solution for diffrent models connected together, but only a few people have it so it still would access a pretty big group of users.

rowak commented 3 years ago

You're right, the device selection popup is probably the next best way to do this, but I likely won't implement it unless I know for certain that it isn't possible to detect the device type based on its name and model. Did you try running that program I linked in my last comment? (https://ufile.io/qba5c21u) It gets the name and model from your device. If you provide your Shapes Triangles device name and model I can possibly add auto-detection in the app for it.

resteqs commented 3 years ago

No haven't yet. I will try later

chn0x commented 2 years ago

I also have the Shapes Triangles. I ran the program you provided, and it output this:

Name: Shapes C83F Model: NL42 Manufacturer: Nanoleaf Firmware version: 6.1.2

rowak commented 2 years ago

Thanks! I'll whitelist the shapes triangles.

These are still unsupported in the app though, and I don't plan on adding support for them right now. Out of curiosity, have you tested any of the other functions in the app with the shapes triangles? Does anything else appear broken?

rowak commented 2 years ago

Hey, I whitelisted the shapes triangles, so they should be recognized by the app now. You can download an updated build here.

chn0x commented 2 years ago

They are indeed recognized as triangles now. The preview shows one solid colour for every panel instead of what each triangle is currently displaying, but I don't care about that. I tried out Basic Effects, Color Effects, and Rhythm Effects, and those worked as expected. The Control, Discovery, Ambient Lighting, and Spotify Visualizer work as expected save for the most recent comment I made on the other issue (#35).

Thank you.

rowak commented 2 years ago

Thanks for the info! I'm surprised that the triangles work so well with the app already.