search

rowan-vr / CustomAdvancements

Custom Advancements is an easy to configure minecraft plugin where you can create your own advancements for your server. Your players can use the easy to use GUI to see the advancements and their progress and how to activate them!
https://www.spigotmc.org/resources/custom-advancements.91167/
GNU General Public License v2.0
34 stars 7 forks source link

Ported to v1.20 #143

Closed Chris221 closed 1 year ago

Chris221 commented 1 year ago

They updated to 1.20.1 so I also included that

1.20.1 uses the same protocols and runs the 1.20 version: https://www.spigotmc.org/threads/spigot-bungeecord-1-20-1-20-1.606939/

Tested and confirmed no warnings/errors to the console

rowan-vr commented 1 year ago

Thank you for your contribution! I will review it once I wake up!

On Jun 12, 2023 at 8:02 PM, <Christopher Siena @.***)> wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/rowan-vr/CustomAdvancements/pull/143

Commit Summary

d8174dc (https://github.com/rowan-vr/CustomAdvancements/pull/143/commits/d8174dc974c4f3c6bc32c079be7faf8c897366a2) 1.20 port

e3b275b (https://github.com/rowan-vr/CustomAdvancements/pull/143/commits/e3b275baade85be6d8ba40592dbfe5c4791f4ccc) Update maven-publish.yml

995bac4 (https://github.com/rowan-vr/CustomAdvancements/pull/143/commits/995bac4eb7ef08c396f6146085e4fac6c3c1ae2a) Update maven-publish.yml

934161a (https://github.com/rowan-vr/CustomAdvancements/pull/143/commits/934161ae26407c61b76e344a7e2368fa8eb5adc8) Update maven-publish.yml

ed34dbe (https://github.com/rowan-vr/CustomAdvancements/pull/143/commits/ed34dbe098c53c1be561d6fa7ec13dd121ca8dc1) Merge branch 'main' into 1.20

ef2ea4b (https://github.com/rowan-vr/CustomAdvancements/pull/143/commits/ef2ea4bcdb3deef5127f93da6f89ee3d99375bff) Update maven.yml

File Changes

(6 files (https://github.com/rowan-vr/CustomAdvancements/pull/143/files))

M .github/workflows/maven-publish.yml (https://github.com/rowan-vr/CustomAdvancements/pull/143/files#diff-a31c6ada558b9f058a611b68d3f9cb0b9a901072c89d38fddc03cf929ef01e8a) (52)

M .github/workflows/maven.yml (https://github.com/rowan-vr/CustomAdvancements/pull/143/files#diff-5dbf1a803ecc13ff945a08ed3eb09149a83615e83f15320550af8e3a91976446) (52)

M dist/pom.xml (https://github.com/rowan-vr/CustomAdvancements/pull/143/files#diff-2681b51a40a6a26d3a6f7f839cd810422226193ef273ea02d1b0b93c3a87cfa6) (5)

M pom.xml (https://github.com/rowan-vr/CustomAdvancements/pull/143/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8) (1)

A spigot_1_20_R1/pom.xml (https://github.com/rowan-vr/CustomAdvancements/pull/143/files#diff-163e738c905bc5047822c625ec969fe4ec2f7d045291263690140db1d5987386) (116)

A spigot_1_20_R1/src/main/java/me/tippie/customadvancements/v1_20_R1.java (https://github.com/rowan-vr/CustomAdvancements/pull/143/files#diff-26ace8d937bf50ee3ef4d5510361ca74e24e1ca51ad393d6f689ee9f15c21fb4) (433)

Patch Links:

https://github.com/rowan-vr/CustomAdvancements/pull/143.patch

https://github.com/rowan-vr/CustomAdvancements/pull/143.diff

— Reply to this email directly, view it on GitHub (https://github.com/rowan-vr/CustomAdvancements/pull/143), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AF3TQRO7FV7VC4GYBIQIKQLXK5KSLANCNFSM6AAAAAAZDXKONM). You are receiving this because you are subscribed to this thread.Message ID: @.***>

SirCraftypants commented 10 months ago

@Chris221

Hi,

Any chance you can update it to 1.20.2 please, i'll donate to you £10, if you add some new advancement types also i'll up it to £20.

https://github.com/rowan-vr/CustomAdvancements/issues/134

SirCraftypants commented 9 months ago

Nevermind, i've given up and moving on, offer to pay recinded.

Chris221 commented 9 months ago

Nevermind, i've given up and moving on, offer to pay recinded.

@SirCraftypants I don’t really care, it’s not mine to money off of bud