Open danielsht86 opened 4 years ago
Have you tried passing a different SECRET than secrets.GITHUB_TOKEN
?
I am not 100% sure but I remember getting a similar error which was resolved passing a SECRET which had the correct/needed authorizations.
The GitHub Token contained in the workflow is the correct one. You can use:add a personal token, but than the action will act under your name in the PR.
I created an issue in core/octocit, because it happens in the library not the action code itself.
Maybe this issue is fixed in newer version.
Ok, I also get this issue in my Organisation Repo. The Failing API is https://developer.github.com/v3/pulls/review_requests/#create-a-review-request
await client.pulls.createReviewRequest(
{
owner: issue.owner,
repo: issue.repo,
pull_number: issue.number,
reviewers: persons,
team_reviewers: teams
}
)
@danielsht86, @adipatel please try to prefix your Organisation Name in front of the Team Name, that removes the Failure e.g.
teams:@<Org>/<team>
@danielsht86 is this still a thing?
@danielsht86 is this still a thing?
I no longer have access to the codebase where this was an issue, so am unable to verify that this has been resolved. Feel free to close this.
Could we reopen this? I could reproduce the issue: https://github.com/percona/mongodb_exporter/pull/254
https://github.com/percona/mongodb_exporter/actions/workflows/ready-for-review.yml
I tried workaround it with adding prefixes to the team, action succeeds but it actually doesn't assign the team:
Adding teams: teams:@percona/pmm-review-exporters
Request Status:201, Teams:
I am facing the same issue action succeeds but team is not getting assigned. Do we need to give additional permissions to GITHUB_TOKEN ? Any pointers would be appreciated. Thankyou
Issue still exists
I was getting a very similar error with another action when trying to add a team as a reviewer. I'm using a GitHub App, and had to add read-only access to Members to get it to work. Just throwing this out there in case this helps anyone!
Thanks @irphilli I’ll add this to the readme
@rowi1de @irphilli could you please elaborate? Read only access for the team members? If I don't use App, what perm should I give to whom?
I’ve just encountered the same Could not resolve to a node with the global id of
issue and the solution was quite effortful, so I hope this helps:
${{ secrets.GITHUB_TOKEN }}
, which misses the required permissions to add teams as reviewers.repo
permissions (click the top-level repo
checkbox).repo-token
in the GitHub action itself to use the new secret, e.g. repo-token: ${{ secrets.NAME_OF_MY_SECRET_CONTAINING_PAT_WITH_REPO_ACCESS }}
instead of repo-token: ${{ secrets.GITHUB_TOKEN }}
teams
for the GitHub action configuration, use just the last part of the full organization team name. If your team is @myFancyCompany/myTeam
, use teams: 'myTeam'
As this is an underlying permission issue, I believe this isn’t a bug but could justify a section in README.md.
@lukasnagl thanks for the detailed description, feel free to create a PR :)
Looks like currently it is possible to add team to CODEOWNERS and that would add team during PR creation and assign ppl: https://github.com/percona/pmm/blob/main/.github/CODEOWNERS#L1
Adding CODEOWNERS imposed different restrictions / implications. This is why this Action was created
@lukasnagl thanks for that explanation, any idea what permissions I'd need to authorize if I use a Github App to authenticate?
I've set up the following workflow:
and I've verified that the action is getting called. However, I'm getting the following error when it's run:
It appears that if I type a non existing team, I don't get any errors. But if I type the team that does exist (which has write access to my repo btw), I get this error. Not sure if this is a bug, or user error. Any pointers would be appreciated. Thanks!