search

rowingdude / analyzeMFT

MIT License
423 stars 117 forks source link

Use windows filepath seperator #37

Closed lespea closed 8 years ago

lespea commented 8 years ago

Since we're parsing MFTs it makes sense to use the windows path separator not unix

dkovar commented 8 years ago

Greetings,

How thoroughly did you test this change? It looks reasonable and correct but changing something fairly fundamental gives me pause.

Thanks for using, and improving this!

-David

lespea commented 8 years ago

Not very, I'll put some more time into it. This could also probably sit behind a flag so the default way is kept but the caller can switch it at runtime. I'm in a meeting now but I should have time later today or at worse, tomorrow.

dkovar commented 8 years ago

Greetings,

Aye, if you could put it behind a flag, that’d be the safest course of action. Then we can let uses QA it. :)

-David

On May 26, 2016, at 3:51 PM, Adam Lesperance notifications@github.com wrote:

Not very, I'll put some more time into it. This could also probably sit behind a flag so the default way is kept but the caller can switch it at runtime. I'm in a meeting now but I should have time later today or at worse, tomorrow.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/dkovar/analyzeMFT/pull/37#issuecomment-221990738

lespea commented 8 years ago

I ran this against a few different MFTs and it looks okay from my end. You'll probably want to double check. I left the default as it was before so it will only be enabled if the user wants this feature.