search

rowtype-yoga / purescript-protobuf

Google Protocol Buffers for PureScript
http://pursuit.purescript.org/packages/purescript-protobuf/
BSD 3-Clause "New" or "Revised" License
54 stars 5 forks source link

conformance test stdin race #26

Closed jamesdbrock closed 2 years ago

jamesdbrock commented 3 years ago

There is a race condition in the conformance test runner which often causes false test failures.

The problem is that I can't figure out how to read all of stdin from a PureScript Node program.

Here is one attempt at solving it. https://github.com/xc-jp/purescript-protobuf/commits/getstdin

On Slack Harry Garrood suggested https://functionalprogramming.slack.com/archives/C717K38CE/p1621308384001100 that I should look at how reading from stdin is done in Pulp.Exec: https://github.com/purescript-contrib/pulp/blob/master/src/Pulp/Exec.purs

jamesdbrock commented 2 years ago

Solved in v3.0.0 with https://pursuit.purescript.org/packages/purescript-node-streams-aff