search

rowyio / rowy

Low-code backend platform. Manage database on spreadsheet-like UI and build cloud functions workflows in JS/TS, all in your browser.
http://rowy.io
Other
6.14k stars 487 forks source link

columnkey update to parentlabel for subtable #1380

Open hrutik7 opened 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Updated (UTC) | | :--- | :----- | :------ | :------ | | **rowy-typedoc** | ⬜️ Ignored ([Inspect](https://vercel.com/rowy/rowy-typedoc/5BboD7jEM9pV1Zj2LoveiSeBcjhG)) | [Visit Preview](https://rowy-typedoc-git-fork-hrutik7-columnkeyupdate-rowy.vercel.app) | Aug 16, 2023 4:39pm |
vercel[bot] commented 1 year ago

@hrutik7 is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

il3ven commented 1 year ago

@shamsmosowi I am trying to merge this PR. Can you confirm the following?

Is this according to the design?

Is subcollectionid the correct name for the config?

https://github.com/rowyio/rowy/blob/d703f9ec53f7e47811f87c8cdc71c812c9766749/src/components/fields/SubTable/Settings.tsx#L35-L38

shamsmosowi commented 1 year ago

@shamsmosowi I am trying to merge this PR. Can you confirm the following?

Is this according to the design?

Is subcollectionid the correct name for the config?

https://github.com/rowyio/rowy/blob/d703f9ec53f7e47811f87c8cdc71c812c9766749/src/components/fields/SubTable/Settings.tsx#L35-L38

the design is good, and it should be subcollectionId