fix: #1483 Applying filters using table

rowyio / rowy

Low-code backend platform. Manage database on spreadsheet-like UI and build cloud functions workflows in JS/TS, all in your browser.

http://rowy.io

Other

5.88k stars 479 forks source link

fix: #1483 Applying filters using table #1486

Closed zeeshan1212 closed 8 months ago

zeeshan1212 commented 9 months ago

/claim #1483

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

vercel[bot] commented 9 months ago

@zeeshan1212 is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

il3ven commented 9 months ago

@zeeshan1212 Thank you very much for the contribution. The PR does fix the bug. Instead of using default input for Number_ component can you pass in onSubmit from the filters component?

https://github.com/rowyio/rowy/blob/80b2f0fbe7551b3184a30574d70567292acb5c75/src/components/TableToolbar/Filters/FilterInputs.tsx#L157-L179

In the above file, we can write onSubmit = () => {} like onChange and it should fix the bug

Reasons for this change:

Default input fixes this bug for Number input field but the bug can be still be there for other input types.

zeeshan1212 commented 8 months ago

@zeeshan1212 Thank you very much for the contribution. The PR does fix the bug. Instead of using default input for Number_ component can you pass in onSubmit from the filters component?

https://github.com/rowyio/rowy/blob/80b2f0fbe7551b3184a30574d70567292acb5c75/src/components/TableToolbar/Filters/FilterInputs.tsx#L157-L179

In the above file, we can write onSubmit = () => {} like onChange and it should fix the bug

Reasons for this change:

Default input fixes this bug for Number input field but the bug can be still be there for other input types.

yeah sure

zeeshan1212 commented 8 months ago

@il3ven changes addressed! please check https://github.com/rowyio/rowy/pull/1486/commits/3ec15f0121d3abba45a6a3cb05e839122830c80c