Open bofeiw opened 7 months ago
/bounty $50
/attempt #1527 can i be assigned?
Algora profile | Completed bounties | Tech | Active attempts | Options |
---|---|---|---|---|
@rajdip-b | 9 bounties from 5 projects | TypeScript, JavaScript, Jupyter Notebook & more |
Cancel attempt |
@bofeiw hey, I tried to reproduce the issue. But it seems like it is working for me. Am I doing something wrong?
Is the issue is still open I am interested in working on this !
/attempt #1527
/attempt #1527
Describe the bug
If there are out of order rows, they are always displayed regardless of the sorts or filters.
Here is an example screenshot of the issue. Filter is set to percentage=0.1 however there are rows whose percentage is 0 appearing in the UI. Notice that the row counter displays "loaded all 48 of 13 rows" which is incorrect.
The cells with dotted red lines are the columns that require a value but those rows do not have a value. They are the "out of order" rows, and with the current code logic, those out of order rows have a high priority for display.
https://github.com/rowyio/rowy/blob/0099bd1daca3f722b05ebbd5294eb31837382b2d/src/atoms/tableScope/table.ts#L171
tableRowsDbAtom
contains rows that are filtered,tableRowsLocalAtom
contains rows that are out of order.tableRowsAtom
combines the two row sets and the table UI directly renders them. This causes the our of order rows to always display in the table UI.The "loaded all 48 of 13 rows" issue with the row counter is also related here. 48 is the combined number of rows (
tableRowsAtom
), 13 is the correct Firebase server count rows with filters.To Reproduce Steps to reproduce the behavior:
https://github.com/rowyio/rowy/discussions/1315 is an example of this issue.
Expected behavior Out of order rows should work with filters/sorts.
Possible solutions
tableRowsAtom
. This is the simplest solution.