search

roxas75 / rxTools

rxTools
http://www.rxtools.net/
GNU General Public License v2.0
266 stars 81 forks source link

Fix Chinese translation #389

Closed mxalbert1996 closed 8 years ago

Syphurith commented 8 years ago

Could you please tell me what you did exactly in description of this pull request? Is some of them fixed and some useless entries removed? Tab and space could sometime be a problem, just check the File Changed page in this pull.. And happy new year festival!

mxalbert1996 commented 8 years ago

@Syphurith Well I fixed some inaccurate and wrong translations. Just changed to Tab to match the English lang file. And Thanks!

urherenow commented 8 years ago

Looking at this file and change confuses the hell out of me. I can't tell when and where "%ls" is needed. Some lines have it. Some lines don't. Some have it after the kanji. Some have it in the middle (kanji both before and after). Some have it multiple times in a row...

Can someone please explain or at least post a link to a good doc about it?

mxalbert1996 commented 8 years ago

@urherenow %ls represents the string argument used to fill in the sentence. For the details of swprintf function and the specifiers you can look at http://www.cplusplus.com/reference/cstdio/printf/ and http://www.cplusplus.com/reference/cwchar/swprintf/. Maybe looking at the en.json would be easier to understand.

RandomIntermition commented 8 years ago

not 100% sure but i'm pretty sure LINE 65 says 'reservation/retention'? wouldn't a word for save/preserve make a better translation? or are retain and retention the same in simp'chinese? :S just a minor thing, can still be understood i know but 'the better the better' right ;)

mxalbert1996 commented 8 years ago

@RandomIntermition Thanks for advice :)

RandomIntermition commented 8 years ago

yes, that sounds better now. had a second look top to bottom and didn't notice any other 'errors'. :)