search

roxas75 / rxTools

rxTools
http://www.rxtools.net/
GNU General Public License v2.0
266 stars 81 forks source link

fixed ImageMagick compatibility, updated Readme.md and Makefile bug #416

Closed dukesrg closed 8 years ago

dukesrg commented 8 years ago
mariogamer2 commented 8 years ago

For me,on linux and latest image magick, I just applyed these change: #415 and its worked.

RandomIntermition commented 8 years ago

@mariogamer2 that pull was canceled because it fixed the same bug that this fixes. it just does it using brackets rather than a rename and includes a series of other fixes, so best just waiting until this is merged then rebuilding. shouldn't encounter any errors.

mxalbert1996 commented 8 years ago

Built this commit on Ubuntu with ImageMagick 6.9.3-3 and the UI is broken. Tested on O3DS and N3DS many times and it always displayed like this. rx_bug Built 33858cd with ImageMagick 6.9.2-10: No problem. 1913cbb with ImageMagick 6.9.2-10: No problem. 1913cbb with ImageMagick 6.9.3-3: Broken UI.

dukesrg commented 8 years ago

@mxalbert1996 that means theme files generation is already broken in 9.3.3-3, didn't check that, only fixed font for now. Just stay on 9.2, I'll check how to fix theme generation tonight.

capito27 commented 8 years ago

@dukesrg i have confirmed this compiles fine in windows (no warped theme files), shall i wait for you to finish checking theme generation on linux before merging or not ?

dukesrg commented 8 years ago

@capito27 I only have a windows toolchain. Anyway this PR won't affect theme at all, so you can merge.

dukesrg commented 8 years ago

@capito27 Checked theme with 6.9.3-3 and 6.9.3-4 - canvas size with raw formats are totally messed up. Any operation involving canvas resize (rotate, transpose etc) causes resulting theme file to be of size 320x320 (while verbose reports it is 240x320). Can't workaround it with page/repage/size/crop, it is just not working as intended. So, for now #397 and #412 should be closed, because actually font generation was adopted. Or at least merged in one and renamed with something like "ImageMagic bugs".