roxiness / routify-starter

https://example.routify.dev/
198 stars 55 forks source link

Warning about mixed content when loading TVMaze images #40

Closed jpaquim closed 4 years ago

jpaquim commented 4 years ago

Chrome is complaining about loading images from an HTTP source, from an HTTPS-served page.

The problem appears to be related to the image urls returned from the TVMaze API, which start with http://, although https:// versions of the same URLs also seem to work.

The needed change would be somewhere around this <img src>, where the url can be https-prefixed if served from an https domain: https://github.com/sveltech/routify-starter/blob/master/src/pages/example/api/%5BshowId%5D.svelte#L24

jakobrosenberg commented 4 years ago

The example is meant as an example. From a perspective of brevity, rewriting the URL would be counter productive.

Wolfr commented 4 years ago

Closing this because it's stale, and Jakob argumented against doing something in the code.

jpaquim commented 4 years ago

Sure, go ahead 👍