roxiness / routify-starter

https://example.routify.dev/
198 stars 55 forks source link

New rollup.config.js causes infinite rebuild #53

Closed jadbox closed 4 years ago

jadbox commented 4 years ago

When I used the new rollup config, it just repeats building main.js and sw.js over and over: https://github.com/sveltech/routify-starter/blob/master/rollup.config.js

jakobrosenberg commented 4 years ago

Does this happen if you run

npx @sveltech/routify init
npm run build ( or dev)
jadbox commented 4 years ago

@jakobrosenberg it does work (without constant rebuilding) with the steps you provided. Just not sure why it's happening in my project. I'll close this issue as it's probably something special with my project somehow.

jakobrosenberg commented 4 years ago

@jadbox did you figure out what the issue was?

jadbox commented 4 years ago

@jakobrosenberg nope, not sure why yet. I've committed the update to the config branch here: https://github.com/abridged/unroll/tree/config

jakobrosenberg commented 4 years ago

If you're using nollup, it's possible that nollup is watching your project folder and rebuilding on changes. This could cause an infinite build.

jadbox commented 4 years ago

@jakobrosenberg I'm not using nollup, just vanilla rollup with all out of the box configs.

jadbox commented 4 years ago

I found the bug in my project: the rollup prerender() calls npm export and I had decided to add the build step into that npm command... causing infinite building. I removed the build step from export and now! All fixed