search

roxiness / routify-starter

https://example.routify.dev/
198 stars 55 forks source link

Fixed importing tabs animations #69

Closed flymedllva closed 3 years ago

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/jakobrosenberg/routify-starter/9gqyqq4b0
✅ Preview: https://routify-starter-git-fork-flymedllva-master.jakobrosenberg.vercel.app

jakobrosenberg commented 4 years ago

Hi @FlymeDllVa thanks for the PR. I think the local _components/TabsTransition.svelte is an old leftover from before the TabsTransition.svelte was added to Routify.

Did you have any issues before the fix?

flymedllva commented 4 years ago

Hi @jakobrosenberg, there were no problems. But I create this file in the project myself to change config => to change the animation. In General, you can refuse the file, but it is dead weight. But if you leave it, it is a good example of how to change animations.

Tell me, can I somehow index pages in config? At first, I thought routes[0].api.title would work, but in pages with parameters, it doesn't include the page name.

I have a problem with <!-- routify:options bundle=true -->, if you copy files from transitions/tabs/home to the root, the site just doesn't load. Although logically it should load all elements at level 1? The problem is on the 2.0 branch. I haven't tried it on master.

jakobrosenberg commented 4 years ago

<!-- routify:options bundle=true -->, if you copy files from transitions/tabs/home to the root, the site just doesn't load.

It's possible that internal functions rely on a parent node which might not be present at the root level. But that's Just speculation. If you create a minimal reproducible example, I can have a look.

Tell me, can I somehow index pages in config? At first, I thought routes[0].api.title would work, but in pages with parameters, it doesn't include the page name.

Not sure if this is what you're looking for <!-- routify:options index=123 -->

api.path might be more reliable.

flymedllva commented 4 years ago

@jakobrosenberg

It's possible that internal functions rely on a parent node which might not be present at the root level. But that's Just speculation. If you create a minimal reproducible example, I can have a look.

Below is a link to the place where the error occurs. In fact, this is a folder from the demo project copied to the root. Error UPD: I checked. This problem is only on the 2.0 branch. On the master everything works without problems

api.path might be more reliable.

I understand how it works. Thanks