search

roxiness / routify-starter

https://example.routify.dev/
198 stars 55 forks source link

semis, formats and qoutes #84

Closed brgrz closed 3 years ago

brgrz commented 3 years ago

fixes #74

ghostdevv commented 3 years ago

I do like the switch from " to ' I am not sure the semi colons will get through as Jacob isn't a fan, there should really be a origination wide spec for how code is formatted for consistency and that would be up to the core team I imagine.

Nice work though!

brgrz commented 3 years ago

I do like the switch from " to ' I am not sure the semi colons will get through as Jacob isn't a fan, there should really be a origination wide spec for how code is formatted for consistency and that would be up to the core team I imagine.

Nice work though!

Yes I read his reply in the other thread that he dislikes semis. It's up to him whether he merges this or not, I'd just say this: in general people don't have an issue if JS/TS code contains semicolons but many more people are bothered when semis are missing. That's just how I look at that issue.

ghostdevv commented 3 years ago

Not going to merge this since we want to maintain as consistent code style as possible and Jake has done most of it in the code style he likes

jakobrosenberg commented 3 years ago

Actually, with the upcoming templates, this will be automatically solved as you can configure formatting style when generating a template.