$params broken (search params missing) after ~v3.0.0-next.174

andy1li commented 1 year ago

Describe the bugs

$params won't pick up search params any more.
Unnecessary index appears in url. For example:

localhost:1337?foo=bar redirects to localhost:1337/index?foo=bar

screenshot 1:

screenshot 2:

Reproduction

minimal repo:

https://github.com/andy1li/routify-bug-report

System Info

System:
    OS: macOS 11.7.9
    CPU: (4) x64 Intel(R) Core(TM) i5-6360U CPU @ 2.00GHz
    Memory: 481.94 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 18.17.1 - ~/.nvm/versions/node/v18.17.1/bin/node
    npm: 9.6.7 - ~/.nvm/versions/node/v18.17.1/bin/npm
    pnpm: 8.6.12 - ~/Library/pnpm/pnpm
  npmPackages:
    @roxi/routify: next => 3.0.0-next.176
    svelte: latest => 4.2.0
    vite: latest => 4.4.9

jakobrosenberg commented 1 year ago

Thanks for the repro @andy1li . I'll get back to you asap.

jakobrosenberg commented 1 year ago

:tada: This issue has been resolved in version 3.0.0-next.177 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

andy1li commented 1 year ago

Wow, thank you @jakobrosenberg for the lightning fast fix!

BTW, search params seem to add an unnecessary index in url. For example:

localhost:1337?foo=bar redirects to localhost:1337/index?foo=bar

Not sure whether this is an intended behavior.

jakobrosenberg commented 1 year ago

@andy1li thanks for the heads up. That's unintended, but harmless. I'll see if I can fix it.

jakobrosenberg commented 1 year ago

This should be fixed now.

roxiness / routify