search

roxiness / routify

Automated Svelte routes
https://routify.dev
1.87k stars 87 forks source link

Module replacement directive doesn't have any effect #530

Closed mrjgreen closed 1 year ago

mrjgreen commented 1 year ago

Describe the bug

Module replacement using <file>@custom module pattern has no effect. You can see this if you open the "kitchensink > composition" example in this repo.

Screenshot 2023-10-03 at 07 01 57

In this image we are in the "@replace" example, where the default module should have been replaced. It hasn't, as you can see by the title here.

This is still the case as of the most recent release ^3.0.0-next.186

Reproduction

git clone git@github.com:roxiness/routify.git
cd routify
npm install
cd examples/kitchensink
npm run dev

Navigate to http://127.0.0.1:1337/composition/replace

Logs

none

System Info

System:
    OS: macOS 12.5
    CPU: (8) arm64 Apple M1 Pro
    Memory: 103.58 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 16.15.1 - ~/.asdf/installs/nodejs/16.15.1/bin/node
    npm: 7.24.2 - ~/Projects/routify/node_modules/.bin/npm

I've added some failing E2E tests here: https://github.com/roxiness/routify/pull/531

jakobrosenberg commented 1 year ago

:tada: This issue has been resolved in version 3.0.0-next.187 :tada:

The release is available on:

Your semantic-release bot :package::rocket: