search

roxiness / routify

Automated Svelte routes
https://routify.dev
1.88k stars 88 forks source link

Add test for resolve sibling's child #535

Closed yus-ham closed 1 year ago

yus-ham commented 1 year ago

https://github.com/roxiness/routify/blob/507fe597fbcaffae5c3d56ae7f194ac90566b9c7/lib/runtime/helpers/spec/helpers.spec.js#L7-L16

    const res = traverseNode(adminNode, 'posts/[slug]', mockRouter)
    expect(res.name).toBe('[slug]')

In this test, currently res.name is undefined. Is this normal behavior for resolving sibling's child by relative path?

netlify[bot] commented 1 year ago

Deploy Preview for routify-v3-example canceled.

Name Link
Latest commit 14a2085692b5062fd5eb07eac6a58749b8ded6e3
Latest deploy log https://app.netlify.com/sites/routify-v3-example/deploys/655668776992ac0007216ceb
jakobrosenberg commented 1 year ago

Thanks @yus-ham ! 🙏

jakobrosenberg commented 11 months ago

:tada: This PR is included in version 3.0.0-next.197 :tada:

The release is available on:

Your semantic-release bot :package::rocket: