search

roxma / LanguageServer-php-neovim

38 stars 2 forks source link

Incompatible with Neomake #3

Open still-dreaming-1 opened 6 years ago

still-dreaming-1 commented 6 years ago

https://github.com/neomake/neomake/issues/1680

I'm not sure if this is an issue with this plugin or with Neomake. They each work fine separately, but there are issues when using them together.

roxma commented 6 years ago

LanguageClient-neovim and neomake both modifies the signs.

I'm not familiar with the feature. But probably you need to disable one of them. :help g:LanguageClient_diagnosticsEnable

// cc @autozimu

still-dreaming-1 commented 6 years ago

Thanks for trying to help. I created an issue in all 3 plugins now. Ideally I would like to use both because Neomake hooks into more things that provide additional info about code issues that I want to see, but when the PHP language server does provide error messages, the exact error messages it provides are more helpful. I don't see why I can't use both, if they both set a sign to be on, then it should just be on. If they both set it to off, it should just be off. I don't see why they would interfere.

Ideally, they would both add errors to some kind of shared list of errors and then the most important message per line would somehow be determined and displayed from the list.

roxma commented 6 years ago

I cannot reproduce the issue you describe, though.

Is there a minimal vimrc I can start with?

roxma commented 6 years ago

Add reference to https://github.com/autozimu/LanguageClient-neovim/issues/149