search

roxma / nvim-completion-manager

:warning: PLEASE USE https://github.com/ncm2/ncm2 INSTEAD
MIT License
917 stars 49 forks source link

Support goto definition #56

Closed kepbod closed 7 years ago

kepbod commented 7 years ago

NCM has integrated with jedi and it works great, but I am wondering if it could also support goto definition.

fantiq commented 7 years ago

phper hope too

roxma commented 7 years ago

Planning on that.

Currently I’m using jedi-vim for jumping.

Shougo commented 7 years ago

I think you should use LangServer for it. https://github.com/autozimu/LanguageClient-neovim

prabirshrestha commented 7 years ago

Even I think this is out of scope and should be provided by other plugins like LSP.

roxma commented 7 years ago

It would violate the do one thing and do it well principle for NCM to support too much features.

Somehow I still miss easier setup with minimal plugins and go-to-declarations and so on. If I'm doing this I may end up with adding more features and more bugs and more work to do. I haven't figured out a better solution.

I agree that LSP is always a good solution.

sassanh commented 7 years ago

I also think ncm shouldn't support it. There's no significant benefit for having few plugins. It's better to have plugins that each does its own job. If some day I want to use a fork of jedi-vim I can do it easier if it's a stand alone plugin.

roxma commented 7 years ago

Closing. After a while I think this feature is not necessary. And even if it is, it should be done with another plugin, instead of pushing the complexity into ncm.