search

roxma / nvim-yarp

Yet Another Remote Plugin Framework for Neovim
MIT License
230 stars 14 forks source link

Rename neovim to pynvim #26

Closed mcchrish closed 5 years ago

mcchrish commented 6 years ago

I'm getting this error:

[ncm2_core@yarp] Traceback (most recent call last):
[ncm2_core@yarp]   File "/Users/mcchris/.config/nvim/plugged/nvim-yarp/pythonx/yarp.py", line 1, in <module>
[ncm2_core@yarp]     from neovim import attach, setup_logging
[ncm2_core@yarp] ModuleNotFoundError:
[ncm2_core@yarp] No module named 'neovim'
[ncm2_core@yarp] Job is dead. cmd=['/usr/local/bin/python3', '-u', '/Users/mcchris/.config/nvim/plugged/nvim-yarp/pythonx/yarp.py', '/var/folders/fb/nctk069d4rz
83p4b87b4rx_w0000gp/T/nvimAPLsQb/0', 2, 'ncm2_core']

When installing the latest python-client. Solved it by changing the imports. (don't know a lot of python but this seems to solve the issue)

CandySunPlus commented 6 years ago

merge it, please

roxma commented 6 years ago

Why? According to https://github.com/ncm2/ncm2/pull/102 and https://github.com/neovim/pynvim/tree/master/neovim, import neovim still works

Shougo commented 6 years ago

@mcchrish You need to remove neovim package and re-install pynvim is needed. Because the package upgrading doesn't work properly.

roxma commented 6 years ago

Considering that import neovim is still available and pynvim was created 7 days ago. I don't want to break the software for those who install python neovim client using the system package manager, which usually results in older version for point release linux distros.

I should probably merge this PR later.