search

roxrook / alogcat

Automatically exported from code.google.com/p/alogcat
0 stars 0 forks source link

Feature request: Toast shows active filter (patch included) #39

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Sometimes I forget that I have a filter loaded, so I would like the Toast 
notification to show the filter contents if there are any.  I've created and 
tested a patch to do this, I'm attaching it.

Maybe the same sort of method could be used to change the application title 
from aLogcat to "aLogcat [filter contents]"

Thanks for this indispensable app.

Original issue reported on code.google.com by wskellen...@gmail.com on 14 Mar 2012 at 4:24

Attachments:

GoogleCodeExporter commented 9 years ago 
Here is an updated patch that also updates the window title like this:

When (getFilter() != null) you will see:

   aLogCat Filter: [wifi]

else:

   aLogCat

Original comment by wskellen...@gmail.com on 15 Mar 2012 at 3:15

Attachments:

GoogleCodeExporter commented 9 years ago 
thanks for the patch.

i'm not sure that the title bar is the right place. the reason is that it 
doesn't scale. if someone comes along tomorrow and says that it's really 
important to show the log level, and the buffer, and other things, there's no 
logical way to fit them into the title bar.

would a toast, as you suggested work? that way we can put other info into the 
toast if necessary.

Original comment by jeffrey.blattman@gmail.com on 15 Mar 2012 at 11:02

GoogleCodeExporter commented 9 years ago 
Hi Jeffrey,

Yes, I'll admit I'm not much of a GUI programmer.  :)  I went kind of the 
opposite way, and in this last patch I took it out of the Toast because it just 
looked too cluttered.  I've also added the buffer type too and thought about 
the Log Level.  If you push it too far the titlebar will show "...".  It could 
be possible to let the user configure what they want displayed however, knowing 
there is a space limitation.  

Here is a screenshot of the latest, I think it looks pretty good, but it is 
your baby, and up to you Jeffrey.  

Thanks for the consideration.

Original comment by wskellen...@gmail.com on 16 Mar 2012 at 1:23

Attachments: