search

roy-ganz / toql

A friendly and productive ORM
50 stars 1 forks source link

on_sql on #[toql(merge)] ignores default columns #7

Closed roy-ganz closed 2 years ago

roy-ganz commented 2 years ago

Currently on_sql for merge is not documented. Instead join_sql should be used.

In its current behavior it replaces the whole join condition. This is wrong, it should behave like on normal joins and just add an additional join restriction to the default column joins.

roy-ganz commented 2 years ago

Added test case in library and improved guide.