10B requires explictly setting also 9B

royallgroup / TCC

The Topological Cluster Classification algorithm

https://royallgroup.github.io/TCC/

GNU General Public License v3.0

12 stars 5 forks source link

10B requires explictly setting also 9B #108

Closed russojohn closed 5 years ago

russojohn commented 5 years ago

The statistics of clusters differs between 1) analyse_all_clusters is set to 1 2) analysie_all_cluster is set to 0, and 10B is requested without specifying also 9B. If 9B is set, then the two results agree.

Francesco found the fix.

merrygoat commented 5 years ago

9B is needed but is not automatically selected. This is an error in my automatic prerequisite detection, that turns on detection of the smaller required clusters. In a rather poor typo it analysed 9K clusters instead!

This is not the first time this has happened so I will write an automatic test to loop over clusters and make sure they are detected even when their children are not selected.

merrygoat commented 5 years ago

This is in the devel branch for now. Will push this to master once I have written a test in #109