search

royallgroup / TCC

The Topological Cluster Classification algorithm
https://royallgroup.github.io/TCC/
GNU General Public License v3.0
12 stars 5 forks source link

Unit tests require tcc executable in path #60

Closed tranqui closed 6 years ago

tranqui commented 6 years ago

Unit tests fail on @merrygoat's windows machine because the unit test assumes the tcc executable is in the system path. Solution requires either an install feature (e.g. make install as suggested in #59), instructions for adding to the path or a workaround this requirement e.g. by directly locating the executable within the python front end.

tranqui commented 6 years ago

Python front end should locate the executable inside the bin folder (if it has been built) as of 7a8a67d72edfcb02031616651b1e7bf82cef40f0

@merrygoat do the unit tests run for you now?

merrygoat commented 6 years ago

They did not. I have made some modifications on the new branch "unit_tests".

For me the unit tests now pass on all three platforms. It would be good if you could have a look and see what you think. 7T is also now passing, hopefully that method is complete.

The integration tests are borked atm. because of adding the 7T, I will update these and the static_clust file Monday, integrating some of your ideas from the unit tests.

tranqui commented 6 years ago

Confirmed that they are working. I have merged changes into devel branch.