royallgroup / TCC

The Topological Cluster Classification algorithm
https://royallgroup.github.io/TCC/
GNU General Public License v3.0
12 stars 5 forks source link

Remove centers magic numbers #67

Closed merrygoat closed 6 years ago

merrygoat commented 6 years ago

11A and 13A centers can be output to xyz files. The variables to do this are set using magic numbers which are unstable to changing the cluster lists.

Only the centers of a limited number of clusters are interesting - not all clusters even have centers.

There are multiple ways of fixing this:

Which is best depends on how much the xyz centers are used and whether the centers of any other clusters are interesting.

tranqui commented 6 years ago

Would not a cluster-independent method of doing this be to output the center of masses for each cluster? Edit: Care would need to be taken with respect to periodic boundaries, by e.g. unwrapping coordinates when a cluster crosses a boundary.

merrygoat commented 6 years ago

After discussion, the second option seems the most sensible for now.

Larger scale restructuring of the output format is something for a future version > 1.0.