BeatUpServer support / detection

roydejong / BeatSaberServerBrowser

Beat Saber modification that adds a Server Browser to the Online menu, making it easy to share and join custom multiplayer games.

MIT License

102 stars 11 forks source link

BeatUpServer support / detection #68

Closed roydejong closed 2 years ago

roydejong commented 2 years ago

BeatUpServer is not properly recognized by the mod currently.

[x] Server type is announced as "unknown"
[x] Lobby status seems invalid?
[x] Announce fails with HTTP 500 (Internal Server Error) during gameplay

roydejong commented 2 years ago

Announce failure is related to a BeatUpServer issue: https://github.com/rcelyte/BeatUpRcelyte/issues/4

Actual 500 error is related to the duplicate session ID, I'll update the server to deal with that more gracefully.

rcelyte commented 2 years ago

What do you mean by "Lobby status seems invalid"?

roydejong commented 2 years ago

What do you mean by "Lobby status seems invalid"?

I noticed a BeatUpServer lobby that had a status of "None", but I haven't actually been able to reproduce this so far.

I believe the client sets this status on disconnect, so it may have just been unlucky timing with the announce going out. This may just be something I have to patch on the API side.