Closed ajinkya-kulkarni closed 1 year ago
Good point - done
Thanks, I opened a PR to your patch-1
branch to fix a few other things.
I'll merge when the tests are done, thanks!
Thanks!
Merging #1 (00ebcaf) into main (72825eb) will decrease coverage by
1.28%
. The diff coverage is66.66%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #1 +/- ##
==========================================
- Coverage 89.38% 88.10% -1.28%
==========================================
Files 4 4
Lines 179 185 +6
==========================================
+ Hits 160 163 +3
- Misses 19 22 +3
Impacted Files | Coverage Δ | |
---|---|---|
src/napari_segment_anything/utils.py | 88.00% <66.66%> (-12.00%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Hi @ajinkya-kulkarni, thanks for the contribution.
I suggest updating the
get_weights_path
return type hint toOptional[Path]
so it runs withmypy
. And, to leave the trailing spaces on the "Download complete" print, that's used to erase the previous output when using "\r".